[Draft] Ruff as linter #3756
Draft
[Draft] Ruff as linter #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That took ~3 seconds to run. That's insane! Just for unused imports right now. I think we would exclude init files so we could get fancier. But might be worth thinking about. |
for more information, see https://pre-commit.ci
|
Mayeb it is time to switch no ? |
|
Well if we do switch we need to decide what we want. Currently this is set to lint imports only. But we can fine tune this. We could start by switching this to actually do the black formatting and then add rules if we need to get what we want. We can put this on a meeting agenda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to draft out so we could see. Right now if I did it right--though I doubt it haha. This should just check for unused imports... If we like this we could remove black auto commit and switch with a commit action in the future. But just want to see how this flows.